UI: expose network ACL replacement from VPC tiers - #13794
Open
Dogface2k wants to merge 4 commits into
Open
Conversation
Contributor
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13794 +/- ##
============================================
- Coverage 19.65% 19.64% -0.01%
+ Complexity 19792 19788 -4
============================================
Files 6368 6368
Lines 574881 574901 +20
Branches 70351 70352 +1
============================================
- Hits 112970 112946 -24
- Misses 449639 449688 +49
+ Partials 12272 12267 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
@Dogface2k |
|
UI build: ✔️ |
Contributor
@weizhouapache there is now also a button in the vpc tiers overview list. I think that is fine as well. (edit: your sshot is from the tiers details page, this is extra) |
Author
|
isolating VPC tier ACL replacement state |
Dogface2k
marked this pull request as ready for review
August 6, 2026 02:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Expose the existing
replaceNetworkACLListoperation directly from the VPC tiers overview.This is an additional UI entry point. The existing replace-ACL action on an individual tier's detail page remains unchanged.
Scope
replaceNetworkACLListAPIreplaceNetworkACLListis unavailable to the current userBehaviour
A replace-ACL action is shown beside the current ACL for each tier in the VPC tiers overview.
Selecting the action opens a dedicated replacement modal preselected with the tier's current ACL.
The replacement flow has its own:
It does not reuse or mutate the create-tier form state.
showReplaceAclModalremains the boolean modal-visibility state.handleOpenReplaceAclModal()starts a replacement interaction, captures the owning VPC identifier, initializes replacement-only state, and loads the ACL lists belonging to that VPC.handleCloseReplaceAclModal()handles user cancellation. It hides the modal, invalidates the cancelled interaction, and clears replacement-only state so a pending request cannot later update a closed or newer interaction.A validated submission hides the modal without invoking the cancellation handler, allowing the already captured operation to continue.
Each interaction is protected by its generation and owning VPC identifier. Closing the modal, opening another tier, or navigating to another VPC invalidates older ACL-list and validation completions.
This prevents stale asynchronous work from:
Before submission, the selected ACL, owning VPC, target tier, interaction generation, and form reference are captured for that operation.
The encoded request uses the existing API parameters:
aclid;networkid.An older submission completing after another replacement interaction has started continues to report its own captured tier identifier and cannot clear the newer interaction's loading state.
Successful asynchronous completion refreshes the VPC view through the existing
parentFetchDatacallback.The existing create-tier ACL-loading and selection path remains unchanged.
Validation
Focused tests in
VpcTiersTab.spec.jscover:data();aclidand capturednetworkid;The shallow-mounted component tests explicitly render stub default slots so the nested replacement form and overview action are present in the mounted template.
The current-head repository checks should be reviewed before merge.